Skip to content

docs: add Tencent Cloud webhook provider#6432

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
QianChenglong:add-tencentcloud-webhook-provider
May 18, 2026
Merged

docs: add Tencent Cloud webhook provider#6432
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
QianChenglong:add-tencentcloud-webhook-provider

Conversation

@QianChenglong
Copy link
Copy Markdown
Contributor

@QianChenglong QianChenglong commented May 12, 2026

What this PR does

Why

The in-tree Tencent Cloud provider was removed per the webhook migration plan. This webhook implementation supports both DNSPod (public DNS) and PrivateDNS (VPC-scoped) with two credential modes:

  • Static: SecretId/SecretKey — works on any Kubernetes cluster
  • OIDC: TKE RRSA — keyless authentication for TKE managed clusters

References

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 12, 2026

Welcome @QianChenglong!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 12, 2026

Hi @QianChenglong. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 12, 2026
@mloiseleur
Copy link
Copy Markdown
Collaborator

mloiseleur commented May 12, 2026 •
edited
Loading

@QianChenglong Usually, most of the webhook providers keep their tutorials on their repository. That said, I do not have a strong opinion on that, and I'm ok with that. So let's see what the other maintainers think about this.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 12, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented May 12, 2026 •
edited
Loading

Coverage Report for CI Build 26032218756

Coverage remained the same at 80.634%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats

Coverage Status
Relevant Lines: 21403
Covered Lines: 17258
Line Coverage: 80.63%
Coverage Strength: 1450.43 hits per line
💛 - Coveralls

@mloiseleur
Copy link
Copy Markdown
Collaborator

mloiseleur commented May 12, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2026
@ivankatliarchuk
Copy link
Copy Markdown
Member

ivankatliarchuk commented May 16, 2026 •
edited
Loading

Why we need a webhook tutorial docs/tutorials/tencentcloud.md in this repo? You could have up-to-date tutorial in the webhook repo, and keep it up to date against different external-dns versions

@QianChenglong
docs: add Tencent Cloud webhook provider to registry
65ab1cb 
Add external-dns-tencentcloud-webhook to the webhook provider
table in README.md. Supports DNSPod (public) and PrivateDNS
(VPC-scoped) with static credentials or OIDC (TKE RRSA).
@QianChenglong QianChenglong force-pushed the add-tencentcloud-webhook-provider branch from 9b089fe to 65ab1cb Compare May 18, 2026 12:01
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2026
@QianChenglong
Copy link
Copy Markdown
Contributor Author

QianChenglong commented May 18, 2026

Thanks for the feedback @ivankatliarchuk. You're right — I've removed the tutorial and kept only the README registry entry. The detailed tutorial lives in the webhook repo itself: https://github.com/tkestack/external-dns-tencentcloud-webhook

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 18, 2026
@ivankatliarchuk
Copy link
Copy Markdown
Member

ivankatliarchuk commented May 18, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2026
@k8s-ci-robot k8s-ci-robot merged commit f876605 into kubernetes-sigs:master May 18, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivankatliarchuk ivankatliarchuk Awaiting requested review from ivankatliarchuk

@mloiseleur mloiseleur Awaiting requested review from mloiseleur

Assignees

@ivankatliarchuk ivankatliarchuk

@mloiseleur mloiseleur

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@QianChenglong @k8s-ci-robot @mloiseleur @coveralls @ivankatliarchuk